Shouldn't we write a recommended version of PHP?

PHPGangsta / GoogleAuthenticator

PHP class to generate and verify Google Authenticator 2-factor authentication

http://phpgangsta.de/4376

BSD 2-Clause "Simplified" License

2.26k stars 697 forks source link

Shouldn't we write a recommended version of PHP? #85

Open fumiya5863 opened 3 years ago

fumiya5863 commented 3 years ago

The PHP formula says random_bytes is greater than or equal to 7.0

Note: Although this function was added to PHP in PHP 7.0

Wouldn't it be better to write that 7.0 or higher is recommended for README?

MarkMaldaba commented 3 years ago

The code is written with a number of fallbacks. It uses random_bytes() if it is available, but has a number of other alternatives if not. Therefore, the module currently works on a large number of PHP versions, at least as far back as PHP 5.3, if not further (whilst also working on the latest PHP releases).

It might still be worth explicitly stating the versions of PHP that are supported, though.

fumiya5863 commented 3 years ago

Thank you for your comment. Certainly, I think it would be good for future users to list the PHP version in the README.