search

PHPJasper / phpjasper

A PHP report generator
MIT License
469 stars 162 forks source link

chore: Upgrade to JasperStarter 3.6.2 #311

Open Xint0-elab opened 2 years ago

Xint0-elab commented 2 years ago

Upgrade JasperStarter to version 3.6.2

@geekcom Can you please review?

Xint0-elab commented 2 years ago

@geekcom Can you please review this PR?

Xint0-elab commented 2 years ago

@vitormattos Hi Vitor, can you please review this pull-request?

lucasctd commented 2 years ago

@leandrocopam may you? Thx XD

yvescleuder commented 2 years ago

Hi, How do I install this dependency from your project? I need the new version of JasperStartwe, when I try to install by composer using this:

image

It generates an error informing me that the PHPJasper class does not exist. "message": "Class \"PHPJasper\PHPJasper\" not found"

If install from compose require geekcom/phpjasper is it worked... more new version

vitormattos commented 2 years ago

Is too hardy to do this review, have a lot of files.

I think that binary files can't stay in the repository, maybe will be best to move all binaries to other repository and use require to use the external repository or use other approach using environments or other way to define the version/tag of dependencies.

Following with these binaries in this repository also will be very hard to clone and work.

Xint0-elab commented 2 years ago

@vitormattos Including the binary dependencies directly in this repo has the advantage of knowing PHPJasper will work after install, without issues.

geekcom commented 1 year ago

Hi @Xint0-elab, this PR is tested?

Xint0-elab commented 1 year ago

Hi @Xint0-elab, this PR is tested?

Yes, I used my fork in production. But have since switched to using https://github.com/smart145/phpjasper.