search

PHPOffice / PHPExcel

ARCHIVED
Other
11.46k stars 4.2k forks source link

Removed an error for zoom scale in favor of a default value. #1325

Closed jleslie closed 6 years ago

jleslie commented 6 years ago

This error prevents files from going through when in reality it might better to simply default the value on something like zoom scale. The end users of software made using PHPExcel will not know how to handle an error like this.

PowerKiKi commented 6 years ago

Thank you for your contribution, however PHPExcel development for next version has moved under its new name PhpSpreadsheet. So please consider heading over to PhpSpreadsheet to contribute patches and features. Pull Requests will no longer be accepted for PHPExcel.

If you decide to submit a PR to PhpSpreadsheet, we should adopt a similar strategy than in https://github.com/PHPOffice/PhpSpreadsheet/pull/186, that is keep the validation for normal usage, but allow a non-validated value only when reading files.