search

PHPOffice / PHPExcel

ARCHIVED
Other
11.46k stars 4.19k forks source link

Bug in Excel2007/Worksheet.php in count function #1404

Closed alefbox closed 6 years ago

alefbox commented 6 years ago

There is a bug in line 771 in PHPExcel/Writer/Excel2007/Worksheet.php file

https://github.com/PHPOffice/PHPExcel/blob/1.8/Classes/PHPExcel/Writer/Excel2007/Worksheet.php#L771 count($columns > 0) - wrong closed scope place, it must be count($columns) > 0

In php 7.2 this causes Countable error

PowerKiKi commented 6 years ago

Duplicate of #1334

PowerKiKi commented 6 years ago

Duplicate of #1376