search

PHPOffice / PHPExcel

ARCHIVED
Other
11.46k stars 4.2k forks source link

Branch: 1.9. There is no file BaseReader #727

Open e-oz opened 8 years ago

e-oz commented 8 years ago

All readers are extending BaseReader, but there is no such class. Maybe you forgot to copy "Abstract.php" from previous version. Try to use PHPStorm or IntelliJ IDEA with PHP plugin - refactoring of namespaces (and any other refactoring) is much more easy with automated tools.

okneloper commented 8 years ago

I confirm this. It's a shame the issue is more than a month old and no one has even commented on it.

okneloper commented 8 years ago

Sorry, my composer was accidentally set to minimum stability dev, so it installed dev-master with composer require phpoffice/phpexcel which was essentially not functional.

No that critical then.

MarkBaker commented 8 years ago

I'm going to delete the 1.9 branch for good, and just keep it all on my laptop until the work is complete, and hope that I don't have any kind of laptop failure or get run over by a bus in the meanwhile...... THE 1.9 BRANCH IS NOT STABLE, IT IS NOT FOR USE UNTIL COMPLETE, IT IS MY OFFLINE BACKUP

okneloper commented 8 years ago

Sorry for the above, you're doing a great job! Make sure you backup your laptop frequently :) Maybe put it on bitbucket to be on the safe side.

Thank you.