Template Processor Persist File After Destruct

PHPOffice / PHPWord

A pure PHP library for reading and writing word processing documents

https://phpoffice.github.io/PHPWord/

Other

7.24k stars 2.69k forks source link

Template Processor Persist File After Destruct #2545

Closed oleibman closed 8 months ago

oleibman commented 8 months ago

Description

Replace PR #2542.

Fix #2539. Inadvertent break in TemplateProcessor behavior after #2475. Deleted temp file on destruct. It will now persist after destructor.

Checklist:

[x] I have run composer run-script check --timeout=0 and no errors were reported
[x] The new code is covered by unit tests (check build/coverage for coverage report)
[ ] I have updated the documentation to describe the changes

coveralls commented 8 months ago

coverage: 97.217% (-0.001%) from 97.218% when pulling 8cb119fea1efd3081291d2b0d344e955806d2d15 on oleibman:nounlink3 into 98d038e05d2c9c0bf483a0c22118438a69853c49 on PHPOffice:master.

Progi1984 commented 8 months ago

Thanks @oleibman for your contribution

kevinpapst commented 8 months ago

Thanks for tackling the issue 👍

Maybe-U commented 8 months ago

Thanks @oleibman for your contribution please review my code thanks a lot https://github.com/PHPOffice/PHPWord/pull/2547