search

PHPOffice / PHPWord

A pure PHP library for reading and writing word processing documents
https://phpoffice.github.io/PHPWord/
Other
7.16k stars 2.68k forks source link

[BUGFIX] Remove invalid tool call from composer `check` script #2600

Open sbuerk opened 3 months ago

sbuerk commented 3 months ago

With commit [1] development dependencies have been removed from the composer.json, but not from the composer.lock.

This indicates a inproper use of composer and should be taken care in review of pull-requests. A good practice here is to etablish a rule that composer commands needs to be added to the commit message and the pull-request.

Other removed dependency and downgraded dependencies have been fixed or readded meanwhile, still missing the phpcs tool for the check composer script.

The CONTRIBUTION.md states to execute composer check before creating a pull-request, which is literally broken due to the missing dependency.

This change removes the php sniffer call from the check script. Additionally, the composer scripts are enhanced to use the same php binary used to invoke composer itself to mitigate issues using the wrong php version on systems with multiple php version binaries.

Further consideration should be to use the check command in the Github Action workflow to have a border if development toolchain is gonna be broken with a change.

coveralls commented 3 months ago

Coverage Status

coverage: 97.217%. remained the same when pulling 1dab8eea885d764a7ff48c9b0131b4488d4c09b4 on sbuerk:stefan-4 into 8b891bb6842dd383f679b47898fad0b7c181f325 on PHPOffice:master.