PHPOffice / PHPWord

A pure PHP library for reading and writing word processing documents
https://phpoffice.github.io/PHPWord/
Other
7.24k stars 2.69k forks source link

dompdf version bump to include 3.0 when? #2621

Closed jurchiks closed 4 weeks ago

jurchiks commented 3 months ago

Describe the problem

Currently PHPWord only supports dompdf/dompdf ^2.0, but recently dompdf released v3: https://github.com/dompdf/dompdf/releases/tag/v3.0.0

Judging from the changelog and diff (https://github.com/dompdf/dompdf/compare/v2.0.8...master), there don't seem to be any BC breaks, certainly no API breaks, aside from very few type additions to method signatures, which shouldn't break anything.

This would indicate that bumping the version requirement to dompdf/dompdf ^2.0 || ^3.0 shouldn't cause any problems.

Currently I cannot update my own dompdf version because it conflicts with the phpword requirement, which is, understandably, a pain in the ass.

Describe the expected behavior

Dompdf ^3.0 is supported.

Priority

Progi1984 commented 4 weeks ago

@jurchiks This issue has been fixed by a maintainer. You can help him by sponsoring him through Github sponsors.