fix: Support Header elements within Title elements

PHPOffice / PHPWord

A pure PHP library for reading and writing word processing documents

https://phpoffice.github.io/PHPWord/

Other

7.28k stars 2.7k forks source link

fix: Support Header elements within Title elements #2674

Open SpraxDev opened 2 months ago

SpraxDev commented 2 months ago

Description

We encountered issues with a Word document where this is a valid combination. This fixes parsing the document properly.

~~Fixes # (issue)~~ No open issue found (but similar to #2616)

Checklist:

[x] My CI is :green_circle:
[x] I have covered by unit tests my new code (check build/coverage for coverage report)
[x] ~~I have updated the documentation to describe the changes~~ Does not apply
[x] I have updated the changelog

SpraxDev commented 2 months ago

Is a test case needed for this kind of change? Do you have a recommendation on where to put it?

coveralls commented 2 months ago

coverage: 96.918%. remained the same when pulling 4c7aaeb373c04932980ab4070aa35374631abf46 on SpraxDev:fix/support-header-within-title into f0ec497cfc6a2880f755c4f761f784b5ef3078fe on PHPOffice:master.