Closed xklid101 closed 1 month ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue for you, please try to help by debugging it further and sharing your results. Thank you for your contributions.
Reopening. It seems a bit odd, but legitimate. Expect a fix in a day or two.
This is:
What is the expected behavior?
when reading - do not set xml attribute showGridlines from element sheetView to true when xml attribute gridlinesSet from element printOptions is true
What is the current behavior?
when reading - xml attribute showGridlines from element sheetView is set to true when xml attribute gridlinesSet from element printOptions is true
What are the steps to reproduce?
Just read any xlsx file saved in a way that has gridlines invisible for sheetView (showGridLines="false") and contains printOptions element with attribute gridLinesSet="true"
e.g. in sheet1.xml
after reading this file, the result created with phpspreadsheet will allways have showGridLines="true" in sheetView
and it is because of this part of code in reader (mainly the first "if" block) https://github.com/PHPOffice/PhpSpreadsheet/blob/1.6.0/src/PhpSpreadsheet/Reader/Xlsx.php#L880-L885
and according to some specification i've found, the code highlighted should change into this:
Which versions of PhpSpreadsheet and PHP are affected?
phpspreadsheet 1.6.0 any php version
Specification that i've found can be downloaded here https://www.iso.org/standard/71691.html
and contains
so nothing about sheetView, but only about printing