Closed leegarner closed 2 years ago
Hello curious contributor ! Since it seems to be your first contribution, make sure that you've been:
Hello,
You right, I missed that. I will push a fix tomorrow for 8.1 and 9.0 versions as well for Memcache driver too.
But for now, time to sleep !
Cheers, Georges
Note for myself:
Cool, no worries. Glad to know I'm not imagining things.
I will completely refactor this validation part, as it is completely broken and not strict enough along with copy/pasted config from Memcache
Great. It does seem like if there's a socket path then no need to check for server & port, and vice-versa. Wasn't sure how deep you wanted to delve ;)
I pushed the validation really deep xD
The following test file will give you an idea of how deep the validation is now:
The tests passes (except for 8.1 but its due a to a Travis bug not pulling php 8.1.x image correctly), so expect a new release by the end of weeks.
You can however, test it on your side before and give me some feedback before if you want to.
I'll check it out, thanks. It looks like it'll cover all the combinations.
Ran a couple of quick tests, including actual use on my dev site, and it looks good. Thanks.
Ok, I'll merge that tonight ! Thanks for the feedback.
Configuration
Describe the bug Unable to add a path to a Memcached socket. Adding the path to the server config results in
PHP Fatal error: Uncaught Phpfastcache\Exceptions\PhpfastcacheInvalidConfigurationException: Unknown keys for memcached server: path in /tmp/fastcache/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Config.php:121
Adding 'path' to the 2nd array check in Config.php seems to solve the issue, and the socket does work