Configuration validation issue with Memcached socket (path)

[leegarner]

Configuration

• PhpFastCache version: 8.1.1/9.0.1
• PhpFastCache API version: 3.0.0
• PHP version: 7.3 and 8.1
• Operating system: Ubuntu 20.04

Describe the bug Unable to add a path to a Memcached socket. Adding the path to the server config results in PHP Fatal error: Uncaught Phpfastcache\Exceptions\PhpfastcacheInvalidConfigurationException: Unknown keys for memcached server: path in /tmp/fastcache/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Config.php:121

Adding 'path' to the 2nd array check in Config.php seems to solve the issue, and the socket does work

-- a/private/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Config.php
+++ b/private/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Config.php
@@ -117,7 +117,7 @@ class Config extends ConfigurationOption
             if ($diff = array_diff(['host', 'port', 'saslUser', 'saslPassword'], array_keys($server))) {
                 throw new PhpfastcacheInvalidConfigurationException('Missing keys for memcached server: ' . implode(', ', $diff));
             }
-            if ($diff = array_diff(array_keys($server), ['host', 'port', 'saslUser', 'saslPassword'])) {
+            if ($diff = array_diff(array_keys($server), ['path', 'host', 'port', 'saslUser', 'saslPassword'])) {
                 throw new PhpfastcacheInvalidConfigurationException('Unknown keys for memcached server: ' . implode(', ', $diff));
             }
             if (!is_string($server['host'])) {
@@ -186,4 +186,4 @@ class Config extends ConfigurationOption
         $this->optPrefix = trim($optPrefix);
         return $this;
     }```

**To Reproduce**
Steps to reproduce the behavior:
1. Add a socket path to the servers provided to the config.```$cm = CacheManager::getInstance('Memcached', new MemcachedConfig([
    'servers' => [
        [
            'host' => '127.0.0.1',
            'port' => 11211,
            'path' => '/var/run/memcache/memcached.sock',
            'saslUser' => null,
            'saslPassword' => null,
        ]
    ]
]));```

**Expected behavior**
Normal cache connection and usage

**Screenshots**
n/a

**Additional context**

[github-actions[bot]]

Hello curious contributor ! Since it seems to be your first contribution, make sure that you've been:

• Reading and searching out our WIKI
• Reading and agreed with our Code Of Conduct
• Reading and understood our Coding Guideline
• Reading our README If everything looks unclear to you, tell us what 😄 The Phpfastcache Team

[Geolim4]

Hello,

You right, I missed that. I will push a fix tomorrow for 8.1 and 9.0 versions as well for Memcache driver too.

But for now, time to sleep !

Cheers, Georges

[Geolim4]

Note for myself:

• [x] This issue needs a no-regression test.

[leegarner]

Cool, no worries. Glad to know I'm not imagining things.

[Geolim4]

I will completely refactor this validation part, as it is completely broken and not strict enough along with copy/pasted config from Memcache

[leegarner]

Great. It does seem like if there's a socket path then no need to check for server & port, and vice-versa. Wasn't sure how deep you wanted to delve ;)

[Geolim4]

I pushed the validation really deep xD

[Geolim4]

The following test file will give you an idea of how deep the validation is now:

https://github.com/PHPSocialNetwork/phpfastcache/commit/5612795a9c50a710ebb1dfbc82125ed487de8969#diff-ab68cc63ac865591d38d3d60818738423668b5ad0c7be6491c1e080fa193b81d

[Geolim4]

The tests passes (except for 8.1 but its due a to a Travis bug not pulling php 8.1.x image correctly), so expect a new release by the end of weeks.

You can however, test it on your side before and give me some feedback before if you want to.

[leegarner]

I'll check it out, thanks. It looks like it'll cover all the combinations.

[leegarner]

Ran a couple of quick tests, including actual use on my dev site, and it looks good. Thanks.

[Geolim4]

Ok, I'll merge that tonight ! Thanks for the feedback.

[Geolim4]

The fixes has been pushed and releases done

Thank you again.

• 8.1.2
• 9.0.2