Currency ID is only 3 characters

PHPfox-Official / phpfox-v4-issues

phpFox Public Bug Tracker

https://phpfox.com

30 stars 21 forks source link

Currency ID is only 3 characters #2689

Open prepperz opened 5 years ago

prepperz commented 5 years ago

What happened?

The currency ID is only 3 characters. It needs to accomododate more for crypto currencies.

Steps to reproduce:

Admincp > globalization > currencies > new currency > currency ID

What is expected?

Should accomodate more than 3 characters.

Browsers and Devices tested

Chrome on Windown 10

Server information

24 Cores, CentOS 7.6.1810, php7.0.27, apache 2.4.6, MySQL: 5.5.60-MariaDB

...

phpFox version

phpFox 4.7.6 (Upgraded), Material theme

...

Screenshots

harrison05 commented 5 years ago

Currently, our system is using format ISO 4217 to storage currency code in the database, so it only limits 3 characters. I see cryptocurrencies have this format but unofficially, follow https://en.wikipedia.org/wiki/ISO_4217#Cryptocurrencies

How many characters we should limit for this if you don't use ISO 4217 format?

Regards.

prepperz commented 5 years ago

Six should be ok for the time being. More cryptos are being added or developed daily so there isn't a fixed number and there is only going to be more in the future.

harrison05 commented 5 years ago

Ok, we will check this case, because we have some Apps storage currencies id with 3 characters (Include 3rd Apps), if the currency system of phpFox allows more than that limit, it might be a risk for them.

Regards.