PHPfox-Official / phpfox-v4-issues

phpFox Public Bug Tracker
https://phpfox.com
30 stars 21 forks source link

when we set Thread Display: [user=2]mary[/user] why does it not just use Mary instead, like in IOS app #2966

Closed spirogg closed 3 years ago

spirogg commented 3 years ago

Important

Please follow this template!


What's happened?

...when we set Thread Display in apps> comments> settings..

If set to Yes comments will be displayed in a thread format allowing users to reply to specific comments instead of the general item they are commenting on.

why does it not use the username only but instead say

Steps to reproduce:

  1. turn on thread display in comments
  2. then go reply to a user then they reply back to you, then you reply back: it popup [user=2]mary[/user]
  3. in IOS it adss ONLY the username as it should not the brackets etc... > [user=2]mary[/user]

What's expected?

...we should only see the username of the user that you are replying too just like in the IOS app

Browsers and Devices tested

(Example: Chrome on iPhone X, Safari on Macbook, Miscrosoft Edge on Windown 10, Firefox on Ubuntu 16.04, ...)

...chrome

Server information

(Example: CentOS 7, php 7.1 apache)

...centos7 php 7.4

phpFox version

(Example: phpFox 4.6.0)

...4.8.2 fresh install

Screenshots

...

Capture

image

harrison05 commented 3 years ago

Hi @spirogg

We haven't supported this feature on the desktop site yet. So, I will mark this topic as a new feature request.

Regards.

Bjoern3003 commented 3 years ago

I asked for that, 1 Year ago. No update :-(

https://github.com/PHPfox-Official/phpfox-v4-feature-requests/issues/913

spirogg commented 3 years ago

@harrison05 can we ask the team to make this a priority. This is in everyone's website. If we have it on mobile we should be able to have on on desktop please. Talk to @phpfoxdev @phpfoxaccount

harrison05 commented 3 years ago

We're working on this feature. It might available in the next version.

Regards.

harrison05 commented 3 years ago

Implemented in Comments App 4.1.7

Regards.

spirogg commented 3 years ago

@harrison05 i wish I would if explained better. When we post something in feed and we add @michelle (example) it still shows the code instead of name like in comments that you fixed. ?

spirogg commented 3 years ago

[user=2]mary[/user]

This still shows when you go to home page Feed If I try to add a posts or photo or video and tag a user it still shows [user=2]mary[/user] instead of Mary :(

spirogg commented 3 years ago

Comments works great. It not starting a new post

harrison05 commented 3 years ago

[user=2]mary[/user]

This still shows when you go to home page Feed If I try to add a posts or photo or video and tag a user it still shows [user=2]mary[/user] instead of Mary :(

Did you upgrade to phpFox v4.8.4?

spirogg commented 3 years ago

@harrison05 yes. Comments work but starting a new post in feed does Not work.

harrison05 commented 3 years ago

@spirogg It's weird, this improvement is working on our demo site https://v4.phpfox.com/

harrison05 commented 3 years ago

Screen Shot 2021-04-14 at 10 56 42

spirogg commented 3 years ago

@harrison05 the issue is the template. i created my own template - (example createnew template from material, named it mywebsite

i added my logo and favicon saved as default template

now i do the upgrade, to 4.8.4

now I remove files no longer needed find missing settings, then language find missing phrases, then rebuild core theme, then clear cache...

now i try to @harrison05 and it does not work, so i check Material template and set as default clear cache and now it works.

harrison05 commented 3 years ago

Hi @spirogg please follow your post #3008. We will work on it.