PHPfox-Official / phpfox-v4-issues

phpFox Public Bug Tracker
https://phpfox.com
30 stars 21 forks source link

IPV6 Support #2988

Closed lethality closed 3 years ago

lethality commented 3 years ago

What's happened?

I believe #2960 was an attempt to report this issue but it wasn't explained or understood well by both parties. The last_ip_address column in phpfox_user is a VARCHAR(15), it's not long enough to store an IPV6 format address. So if you click on a users IP from the AdminCP's, it will display "Not a valid IP address."

Steps to reproduce:

  1. Log into PHPfox using an IPV6 address
  2. In PHPfox admincp, on the dashboard (latest admin logins), or via the admincp's user browser, you will see the IP as a link, albeit too short.
  3. Verify in database backend, how the IP is stored, mine for example is being truncated to the first 15 characters.

What's expected?

The issue isn't with the display of the IP, it's the storage. for example, my IP is in the format 2a00:23c4:9a16:2e00:9146:4f50:0000:0000 (obscured last characters), but only "2a00:23c4:9a16:" is in the database.

Browsers and Devices tested

Opera on Windows 10 PC

Server information

Centos8, PHP 7-4.14, Apache/nginx

phpFox version

PHPfox 4.8.3

Screenshots

image image image

harrison05 commented 3 years ago

Hi @lethality

We will improve the max length of this field to support store IPv6.

Regards.