Closed lishaduck closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
@MattsAttack, can you review?
Sure! Make sure to log your hours btw. I've been putting rows in there for you when I know you're working on it
App runs and everything passed except for "Check Links". It returned this.
```console Dockerfile:1 -------------------- 1 | >>> FROM node:lts-alpine 2 | RUN apk add --no-cache bash>5.0.16-r0 git>2.26.0-r0 3 | COPY entrypoint.sh /entrypoint.sh -------------------- ERROR: failed to solve: node:lts-alpine: failed to resolve source metadata for docker.io/library/node:lts-alpine: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Alibrary%2Fnode%3Apull&service=registry.docker.io: 401 Unauthorized Warning: Docker build failed with exit code 1, back off 8.163 seconds before retry. /usr/bin/docker build -t 37996e:6436b3e8975343f3a448fb7ce7a6[47](https://github.com/PHS-TSA/nexus/actions/runs/11063663473/job/30740368630#step:2:47)4e -f "/home/runner/work/_actions/gaurav-nelson/github-action-markdown-link-check/d53a906aa6b22b8979d33bc86170567e619[49](https://github.com/PHS-TSA/nexus/actions/runs/11063663473/job/30740368630#step:2:49)5ec/Dockerfile" "/home/runner/work/_actions/gaurav-nelson/github-action-markdown-link-check/d53a906aa6b22b8979d33bc86170567e619495ec" #0 building with "default" instance using docker driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 204B done #1 DONE 0.0s #2 [auth] library/node:pull token for registry-1.docker.io #2 DONE 0.0s #3 [internal] load metadata for docker.io/library/node:lts-alpine #3 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Alibrary%2Fnode%3Apull&service=registry.docker.io: 401 Unauthorized ------ > [internal] load metadata for docker.io/library/node:lts-alpine: ------ Dockerfile:1 -------------------- 1 | >>> FROM node:lts-alpine 2 | RUN apk add --no-cache bash>5.0.16-r0 git>2.26.0-r0 3 | COPY entrypoint.sh /entrypoint.sh -------------------- ERROR: failed to solve: node:lts-alpine: failed to resolve source metadata for docker.io/library/node:lts-alpine: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Alibrary%2Fnode%3Apull&service=registry.docker.io: 401 Unauthorized Error: Docker build failed with exit code 1 ##[debug]System.InvalidOperationException: Docker build failed with exit code 1 ##[debug] at GitHub.Runner.Worker.ActionManager.BuildActionContainerAsync(IExecutionContext executionContext, Object data) ##[debug] at GitHub.Runner.Worker.JobExtensionRunner.RunAsync() ##[debug] at GitHub.Runner.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken) ##[debug]Finishing: Build gaurav-nelson/github-action-markdown-link-check@d[53](https://github.com/PHS-TSA/nexus/actions/runs/11063663473/job/30740368630#step:2:53)a906aa6b22b8979d33bc86170567e619495ec ```
Well, that's failing over on #19, but not here. I mostly meant can you review the code changes and make sure you understand what's going on enough.
I looked over the change files and it seems like it's just dependency updates. Am I missing anything?
I looked over the change files and it seems like it's just dependency updates. Am I missing anything?
Nope, but I can't self-approve PRs. I could just ignore it, but I figured you'd prefer to me be more egalitarian about it.
Nah, if it's just dependency stuff I trust you enough to make the right call.
Description
This PR bumps
flutter_web_auth
to v4 stable,flutter_checks
to v0.1.1, and drops the now-unnecessaryweb_socket_channel
override.Type of Change
Checklist
Tested on
CI