search

PHS-TSA / nexus

The application for movers, shakers, and makers
0 stars 0 forks source link

Auth #22

Closed MattsAttack closed 2 weeks ago

MattsAttack commented 3 weeks ago

Thanks for contributing! Provide a description of your changes below and a general summary in the title. Please look at the following checklist to ensure that your PR can be accepted quickly:

Once you've read over these comments, you should delete them.

Description

Describe your changes in a sentence or two.

This PR...

Which issue does this close? If none, quickly write up a more detailed issue so any non-development-related discussion can go there.

Closes: #issue

Type of Change

Delete all non-applicable categories.

Checklist

Before submitting the PR, please make sure you do the following:

### Checklist
- [ ] Read the Contributing Guidelines.
- [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
- [ ] Fill out this template.
- [ ] Log your hours.
- [ ] Check that commits follow the Angular commit convention, more or less.
- [ ] Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

What device(s) have you tested this on? Delete all non-applicable examples.

MattsAttack commented 3 weeks ago

@lishaduck login button is broken like the signup button. It stops running at the form key conditional in the handleSubmit() method. I've added some log statements and made the handleSubmit call in the log in button async but to no avail. I'm thinking it has something to do with how the form key is being generated but I'm not 100% sure

MattsAttack commented 3 weeks ago

Forgot to mention but the log out method for the log out button is also broken. Gonna look into that more later

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 15.13761% with 185 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/features/auth/presentation/auth/signup_page.dart 0.00% 53 Missing :warning:
...rc/features/auth/presentation/auth/login_page.dart 0.00% 50 Missing :warning:
packages/app/lib/src/utils/api.dart 0.00% 21 Missing :warning:
packages/app/lib/src/app/app.dart 0.00% 16 Missing :warning:
...pp/lib/src/features/auth/data/auth_repository.dart 0.00% 16 Missing :warning:
...ib/src/features/auth/application/auth_service.dart 18.75% 13 Missing :warning:
packages/app/lib/src/app/router.dart 55.55% 8 Missing :warning:
...ttings/presentation/preferences/settings_page.dart 75.00% 5 Missing :warning:
packages/app/lib/env/env.dart 0.00% 3 Missing :warning:
Files with missing lines Coverage Δ
packages/app/lib/src/app/bootstrap.dart 100.00% <100.00%> (ø)
packages/app/lib/src/app/wrapper_page.dart 80.00% <ø> (ø)
...atures/home/presentation/home/local_feed_page.dart 100.00% <ø> (ø)
...atures/home/presentation/home/world_feed_page.dart 0.00% <ø> (ø)
...e/presentation/items/sample_item_details_page.dart 100.00% <ø> (ø)
...ple/presentation/items/sample_items_list_page.dart 86.66% <ø> (ø)
packages/app/lib/src/utils/router.dart 100.00% <100.00%> (ø)
packages/app/lib/env/env.dart 0.00% <0.00%> (ø)
...ttings/presentation/preferences/settings_page.dart 79.16% <75.00%> (-11.75%) :arrow_down:
packages/app/lib/src/app/router.dart 70.73% <55.55%> (-12.61%) :arrow_down:
... and 6 more

... and 1 file with indirect coverage changes