PHS-TSA / webmaster-23-24

Webmaster for the 2023-2024 school year.
https://why-switch.deno.dev/
1 stars 0 forks source link

UI Rewrite #56

Closed lishaduck closed 6 months ago

lishaduck commented 6 months ago

Description

This PR redoes as much of the UI as I can, in modular, step-by-step atomic commits.


Type of Change

Checklist

### Checklist
- [x] Read the Contributing Guidelines.
- [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
- [x] Fill out this template.
- [ ] Log your hours.
- [x] Check that commits follow the Angular commit convention, more or less.
- [ ] Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

lishaduck commented 6 months ago

@MattsAttack, do you a font preference? Arial is boring, and we should load a font ourselves anyway for consistency. Tailwind recommends Inter, but we don't want to have a basic Tailwind site, do we? I'm open to anything that's not hideous.

MattsAttack commented 6 months ago

I use montersont(spelling may be off) on Canva and it looks nice. Your call though as I’m not a font guy

On Wed, May 15, 2024 at 9:05 PM Eli @.***> wrote:

@MattsAttack https://github.com/MattsAttack, do you a font preference? Arial is boring, and we should load a font ourselves anyway for consistency. Tailwind recommends Inter https://rsms.me/inter/, but we don't want to have a basic Tailwind site, do we? I'm open to anything that's not hideous.

— Reply to this email directly, view it on GitHub https://github.com/PHS-TSA/webmaster-23-24/pull/56#issuecomment-2113822721, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARBDWAZX6ANQQ2FG6EN6YBDZCQH4ZAVCNFSM6AAAAABHXIZ2UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTHAZDENZSGE . You are receiving this because you were mentioned.Message ID: @.***>

lishaduck commented 6 months ago

@MattsAttack, Montserrat? I love that font (usually, depends on my mood)!

lishaduck commented 6 months ago

I use montersont(spelling may be off) on Canva and it looks nice. Your call though as I’m not a font guy

I've tried to set this up, but it's slow so it decimates our LCP and CLS. It's actually enough to bother me, so I'm calling it off. Anyway, the tailwind defaults work well enough, the fonts'll be on iphones (at least, they should be), so shouldn't be to inconsistent. We'll be fine. Also, the default fonts look nice anyway. Montserrat looks kinda tacky, I'll admit.

lishaduck commented 6 months ago

We can skip the chatbox change if needed. I've messed with it for quite a bit, and don't know how to fix it. Otherwise, this is ready to go!