search

PHS-TSA / wizards-in-calculus

TSA Video Game Design 2023-2024
3 stars 0 forks source link

Info Labels don't Align Correctly #30

Closed lishaduck closed 6 months ago

lishaduck commented 6 months ago

Contact Details

@lishaduck

What happened?

The info labels don't align correctly in fullscreen (in #28).

Reproduction steps

  1. Start the game.
  2. Go into fullscreen
  3. Notice that info labels are just floating

What should have happened?

They should stick to the top.

Date

2024-02-03

What device are you seeing the problem on?

Macbook Air 2020 (M1)

OS

macOS

Browser

Chrome

Context

Screenshot 2024-02-03 at 4 37 59 PM

Code of Conduct

CC: @iiAzui

MattsAttack commented 6 months ago

I think I know how to fix this. I’ll work on it when I get home.

lishaduck commented 6 months ago

I think I know how to fix this. I’ll work on it when I get home.

Sounds good!

iiAzui commented 6 months ago

Looks like your playing in a old version, the window size is never ment to go past 1280 x 800, also why are you in chrome

lishaduck commented 6 months ago

Looks like your playing in a old version, the window size is never ment to go past 1280 x 800, also why are you in chrome

No, it's the latest. I guess the web build doesn't enforce the screen size, so we'll still need to fix it as it has to be a web game. As for chrome: why not? I was testing the web build.

lishaduck commented 6 months ago

... the window size is never ment to go past 1280 x 800...

...I guess the web build doesn't enforce the screen size, so we'll still need to fix it as it has to be a web game...

Tested it some more. That setting changes the default size but doesn't lock it on desktop. It is this line doing it, right?

iiAzui commented 6 months ago

Idk it was in project settings I also made it so it can't be risized

lishaduck commented 6 months ago

Idk it was in project settings I also made it so it can't be risized

Ah. Must have accidentally reverted that. I do think we should fix it eventually, I think fixing that should be enough for now.

lishaduck commented 6 months ago

Idk it was in project settings I also made it so it can't be risized

Ah. Must have accidentally reverted that. I do think we should fix it eventually, I think fixing that should be enough for now.

I see. That checkmark is weird. I'll push it after testing it in the browser.

lishaduck commented 6 months ago

Idk it was in project settings I also made it so it can't be risized

Ah. Must have accidentally reverted that. I do think we should fix it eventually, I think fixing that should be enough for now.

I see. That checkmark is weird. I'll push it after testing it in the browser.

Yeah. It isn't enforced in the browser, so that fix doesn't do anythingmuch. @MattsAttack, you can give it a shot.

lishaduck commented 6 months ago

This is only mostly related, but I found another bug with the info labels:

Screenshot 2024-02-04 at 9 06 32 PM

The z-index of the bg is behind the rest of the content, which'll also need to get fixed.

iiAzui commented 6 months ago

That's not lable that's the button

On Sun, Feb 4, 2024, 9:07 PM Eli @.***> wrote:

This is only mostly related, but I found another bug with the info labels: Screenshot.2024-02-04.at.9.06.32.PM.png (view on web) https://github.com/PHS-TSA/wizards-in-calculus/assets/88557639/09f7f588-f9c6-4d8c-82b7-118ec5101928

The z-index of the bg is behind the rest of the content, which'll also need to get fixed.

— Reply to this email directly, view it on GitHub https://github.com/PHS-TSA/wizards-in-calculus/issues/30#issuecomment-1926154287, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYEGLFI5MHV5NRSUMFXB3DYSBEIRAVCNFSM6AAAAABCYK7ITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWGE2TIMRYG4 . You are receiving this because you were mentioned.Message ID: @.***>

MattsAttack commented 6 months ago

does it need to be a button or can i change it to a color rect?

iiAzui commented 6 months ago

You can change it, I was just going crazy that day and couldn't find it, I just want a background

On Sun, Feb 4, 2024, 10:05 PM Matthew Wasser @.***> wrote:

does it need to be a button or can i change it to a color rect?

— Reply to this email directly, view it on GitHub https://github.com/PHS-TSA/wizards-in-calculus/issues/30#issuecomment-1926193658, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYEGLA5OQUFJHAITIACQJTYSBK7DAVCNFSM6AAAAABCYK7ITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWGE4TGNRVHA . You are receiving this because you were mentioned.Message ID: @.***>

MattsAttack commented 6 months ago

i gotchu

MattsAttack commented 6 months ago

We should probably edit the camera to just fit whatever resolution normal chrome uses. That way when the judges play it they can do full screen and it looks pretty

lishaduck commented 6 months ago

We should probably edit the camera to just fit whatever resolution normal chrome uses. That way when the judges play it they can do full screen and it looks pretty

I was thinking we shouldn't care about the resolution and place them dynamically. Then they could do it fullscreen, but they don't have to.

lishaduck commented 6 months ago

Aha! We can anchor them.

lishaduck commented 6 months ago

I'm going to try to tackle this one next.

lishaduck commented 6 months ago

I got it working! I just have to hook the score back up and it'll be done.

lishaduck commented 6 months ago

Fixed it! Also found some bugs left over from #42, so it really ought to get merged whether or not you like the approach, for it can be changed later.