PHS-TSA / wizards-in-calculus

TSA Video Game Design 2023-2024
3 stars 0 forks source link

Wizard jump is buggy when going down slopes #33

Open MattsAttack opened 6 months ago

MattsAttack commented 6 months ago

Contact Details

No response

What happened?

I've noticed that when the wizard is moving down a slope the jump doesn't work. When he stops moving it works. This is most likely due to the jump code being something like if touching_floor which means he's technically falling when on the slope

https://github.com/PHS-TSA/wizards-in-calculus/assets/71449347/471cdc74-1bc0-4da0-af25-383e34987c63

Reproduction steps

  1. Go to a down slope
  2. Run and try to jump

What should have happened?

Wizard should be able to jump

Date

2/4/24

What device are you seeing the problem on?

No response

OS

Windows

Browser

No response

Context

No response

Code of Conduct

lishaduck commented 6 months ago

I was just about to file this, but you beat me to it!

iiAzui commented 6 months ago

It's because the wizard is too fast for the slope, we could try increasing gravity on slopes or just increasing gravity in general (try making the floaty 1)

On Sun, Feb 4, 2024, 9:37 PM Eli @.***> wrote:

I was just about to file this, but you beat me to it!

— Reply to this email directly, view it on GitHub https://github.com/PHS-TSA/wizards-in-calculus/issues/33#issuecomment-1926175005, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYEGLGH6WUFBOFOBHI5NYDYSBHX3AVCNFSM6AAAAABCZNSR3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWGE3TKMBQGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lishaduck commented 6 months ago

It's because the wizard is too fast for the slope, we could try increasing gravity on slopes or just increasing gravity in general (try making the floaty 1)

Looked into this, seems like we're literally floating, so it is gravity that'll need a fix. I'll send in a patch.

lishaduck commented 6 months ago

FYI, floaty = 1 breaks all jumping, not just movement while jumping.