PHS-TSA / wizards-in-calculus

TSA Video Game Design 2023-2024
3 stars 0 forks source link

Wowza #76

Closed iiAzui closed 6 months ago

iiAzui commented 6 months ago

Thanks for contributing! Provide a description of your changes below and a general summary in the title. Please look at the following checklist to ensure that your PR can be accepted quickly:

Once you've read over these comments, you should delete them.

Description

Describe your changes in a sentence or two.

This PR...

Which issue does this close? If none, quickly write up a more detailed issue so any non-development-related discussion can go there.

Closes: #issue


Type of Change

Delete all non-applicable categories.

Checklist

Before submitting the PR, please make sure you do the following

Tested on

What device(s) have you tested this on? Delete all non-applicable examples.

iiAzui commented 6 months ago

looks good

iiAzui commented 6 months ago

idk i just did whatever it took to push

On Tue, Mar 19, 2024 at 8:25β€―PM Eli @.***> wrote:

@.**** commented on this pull request.

In game/spawnables/quick_math/quick_math.gd https://github.com/PHS-TSA/wizards-in-calculus/pull/76#discussion_r1531418003 :

  • self.quick_math_label.text = question
  • quick_math_sprite.texture = load("res://assets/sprites/number_balls_blank/1b.png")

Also, this removed putting quick_math in the quick_math node group. Maybe you removed it elsewhere, but I think it's still around.

β€” Reply to this email directly, view it on GitHub https://github.com/PHS-TSA/wizards-in-calculus/pull/76#discussion_r1531418003, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYEGLEJXYUT4BJMIH6NZGLYZDQPRAVCNFSM6AAAAABE2ZGLW2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBXHAYDCMRWGE . You are receiving this because you modified the open/close state.Message ID: @.***>

lishaduck commented 6 months ago

idk i just did whatever it took to push

Fair enough.