search

PHSERIS / paper_trail

The goal of this external module (ext-mod) is to streamline the creation of pdf files in REDCap when it needs to be automatically attached to an upload field in the same project.
MIT License
1 stars 2 forks source link

This assumes webdav #3

Open 123andy opened 2 years ago

123andy commented 2 years ago

https://github.com/PHSERIS/paper_trail/blob/6a70cd03d62e9ba6ad6f43b1107fd403aa7b7cff/use_cases/paper_trail_common.php#L399

123andy commented 2 years ago

Not all users use webdav. This should rely on the Files class to determine storage mechanism.

remifrazierucsf commented 2 years ago

@123andy @alanisem123 I thought I'd put a PR in for this last year.

remifrazierucsf commented 2 years ago

@123andy @alanisem123 I believe this was our commit to correct the storage issue: https://github.com/PHSERIS/paper_trail/compare/master...ucsf-research-tech:paper_trail:master

I thought I'd submitted a PR, but maybe it was a pointer in our email conversation from back then, @alanisem123 .

remifrazierucsf commented 2 years ago

Individual commit here: https://github.com/PHSERIS/paper_trail/commit/e639037156c9572d33acbaadd7ee3e7f642db83d

alanisem123 commented 2 years ago

sounds good - let me see if I can complete the pull request.

remifrazierucsf commented 2 years ago

Submitted as https://github.com/PHSERIS/paper_trail/pull/4. See if @123andy can review; there may be a more elegant or robust way to do this.

123andy commented 2 years ago

Hi @remifrazierucsf - I'm not volunteering to review code for this repo :-). I looked at it after the REDCap con and was excited but the idea of a uniform consent system but am not sure what the status of this repo is given we ran into a few issues. For now, I'm going to keep my separate module for multi-sig-consent that builds custom PDFs and see if I can extend it a bit to do what htis does. I hate having two modules with overlapping functionality but I'm not sure where to go at the moment.

remifrazierucsf commented 2 years ago

@123andy no problem, I get it. :) I can't recall now what we needed from the multi-sig process for our part 11 system that led me to update this one instead of using yours.

It may be worth us getting together to chat about these as well as the two custom PDF template engines out there. They basically all do the same thing but none of them comprehensively. It might be nice to get one solution built and try to PR it into the core codebase.

alanisem123 commented 2 years ago

I must say that the solution on our part was initially intended as "process improvement", then it was leveraged for the eConsent process. Yet, our process and module (the Paper Trail) relies on PHP's iMagick as we need to embed a PDF without losing resolution. In other words, we modify REDCap's PDF class, and PHP configs, so we can effectively meet the institution's requirements for eConsent. That is, the Paper Trail on its own is not the entire solution. I think making the distinction between what's expected from these "PDF-solution" and what expected from the core code is a good first step to take.