Thanks to you both for approving this pull request for the copy_into_f function!
@Matheson, @.> - I agree it would be nice to update the code to use glue_sql_collapse, but I would prefer to leave that for @Whitehurst, @.> as I believe he is more familiar with this function and code.
@Whitehurst, @.***> - can you please add this as an enhancement to the GitHub repo and come back to it when you have time?
From: Alastair Matheson @.>
Sent: Thursday, March 14, 2024 2:29 PM
To: PHSKC-APDE/claims_data @.>
Cc: Kern, Eli @.>; Author @.>
Subject: Re: [PHSKC-APDE/claims_data] Adding parameter/code to allow writing ETL batch ID within copy into command (PR #181)
[EXTERNAL Email Notice! ] External communication is important to us. Be cautious of phishing attempts. Do not click or open suspicious links or attachments.
@alastairmatheson approved this pull request.
Looks good barring any desire to use glue_sql_collapse to simplify code.
Thanks to you both for approving this pull request for the copy_into_f function!
@Matheson, @.> - I agree it would be nice to update the code to use glue_sql_collapse, but I would prefer to leave that for @Whitehurst, @.> as I believe he is more familiar with this function and code.
@Whitehurst, @.***> - can you please add this as an enhancement to the GitHub repo and come back to it when you have time?
Thanks!
Eli
Eli Kern MPH RN | Senior Epidemiologist (he/him) Assessment, Policy Development, and Evaluationhttp://www.kingcounty.gov/health/data Health Sciences Division Public Health - Seattle and King County phone: 206.263.8727 | email: @.***https://owa.kingcounty.gov/owa/redir.aspx?C=TNuruUR_x0mMeOqn6rueKCfnLzCcxdAICR3iDfSS8atu12V25XSLIp_1k_j_A9NKOb-a_2dkPVw.&URL=mailto%3aeli.kern%40kingcounty.gov
From: Alastair Matheson @.> Sent: Thursday, March 14, 2024 2:29 PM To: PHSKC-APDE/claims_data @.> Cc: Kern, Eli @.>; Author @.> Subject: Re: [PHSKC-APDE/claims_data] Adding parameter/code to allow writing ETL batch ID within copy into command (PR #181)
[EXTERNAL Email Notice! ] External communication is important to us. Be cautious of phishing attempts. Do not click or open suspicious links or attachments.
@alastairmatheson approved this pull request.
Looks good barring any desire to use glue_sql_collapse to simplify code.
- Reply to this email directly, view it on GitHubhttps://github.com/PHSKC-APDE/claims_data/pull/181#pullrequestreview-1937751116, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABL6ZKVXWNF6HGOKA3T4KFDYYIJBNAVCNFSM6AAAAABEW2E6RKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZXG42TCMJRGY. You are receiving this because you authored the thread.Message ID: @.***>