search

PIA-Group / BioSPPy

Biosignal Processing in Python
Other
573 stars 274 forks source link

Possible error in timestamps #48

Closed louisabraham closed 5 years ago

louisabraham commented 5 years ago

It seems to me endpoint should be True (the default).

https://github.com/PIA-Group/BioSPPy/blob/212c3dcbdb1ec43b70ba7199deb5eb22bcb78fd0/biosppy/signals/ecg.py#L102-L103

capcarr commented 5 years ago

You're right, thanks ;) This also happens for the other signals (EDA, EMG, ...).

Marina168 commented 3 years ago

Hi! Could you tell my what are you using for measuring EDA signal and which is the unit of measurement for the values from BioSPPy/examples/eda.txt(microsiemeans, ohm ? ). Is that frequency real (1000 Hz)? Isn't it a too high value?

PatriciaBota commented 3 years ago

Hi! Could you tell my what are you using for measuring EDA signal and which is the unit of measurement for the values from BioSPPy/examples/eda.txt(microsiemeans, ohm ? ). Is that frequency real (1000 Hz)? Isn't it a too high value?

Hi, the unit is the ADC value with 12-bit (0-4095) resolution, you can find the transfer function here EDA Sensor Datasheet.pdf.

The choice of 1000Hz can be considered a high value for EDA when you have complexity and memory constrains, however a large sampling rate (SR) might be of interest when exploring spectral characteristics of EDA or decomposition algorithms. Additionally, when using a large SR, you can always downsample the data according to your work methods and goals. In contrast from using a small SR, which might introduce limitations.

Marina168 commented 3 years ago

Thank you very much!

On Mon, Mar 1, 2021 at 8:22 PM PatriciaBota notifications@github.com wrote:

Hi! Could you tell my what are you using for measuring EDA signal and which is the unit of measurement for the values from BioSPPy/examples/eda.txt(microsiemeans, ohm ? ). Is that frequency real (1000 Hz)? Isn't it a too high value?

Hi, the unit is the ADC value with 12-bit (0-4095) resolution, you can find the transfer function here EDA Sensor Datasheet.pdf https://github.com/PIA-Group/BioSPPy/files/6063633/EDA.Sensor.Datasheet.pdf .

The choice of 1000Hz can be considered a high value for EDA when you have complexity and memory constrains, however a large sampling rate (SR) might be of interest when exploring spectral characteristics of EDA or decomposition algorithms. Additionally, when using a large SR, you can always downsample the data according to your work methods and goals. In contrast from using a small SR, which might introduce limitations.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PIA-Group/BioSPPy/issues/48#issuecomment-788165433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOSZH7IJZWKFPBUIP55HNMTTBPLNXANCNFSM4GCPGA3A .