search

PIA-Group / BioSPPy

Biosignal Processing in Python
Other
581 stars 275 forks source link

BCG support proposal #56

Open gcathelain opened 5 years ago

gcathelain commented 5 years ago

Dear Carlos Carreiras,

I appreciate the code that you provide with this signal processing library, especially the tools. I am a PhD student working in Ballistocardiography (cardiac mechanical activity monitoring).

Would you like me to contribute and create a BCG processing section ? I found no other open source Python library in this domain.

Sincerely yours,

Guillaume Cathelain

capcarr commented 5 years ago

Hi @guillaumeCat

Thank you for your interest in BioSPPy and your enthusiasm in contributing to this project. Indeed, it would be interesting to have a module for BCG processing. I think it makes sense to have a separate module for BCG, as there is for ECG and other kinds of signals, following the same structure.

When your code is ready, please submit a PR and we'll review it and add your name to the list of contributors. If your code is based on published research (your own or by others), please don't forget to cite them in the module's docstrings (take a look in the source for the ECG module to see how we've been doing it)

Also, if you can, please add a sample BCG signal that we can add to the examples folder, so that we can test your code.

Kind regards, Carlos

gcathelain commented 5 years ago

Dear Carlos,

Thanks for your support I am on it !

Best

gcathelain commented 5 years ago

Dear Carlos,

I opened a pull request for the BCG section. We can have a video call if you want.

Kind regards

Guillaume

capcarr commented 5 years ago

Hi @guillaumeCat

Thanks for your contribution. We'll review your code as soon as possible. How would you like to be cited in the Authors file?

gcathelain commented 5 years ago

Hi @capcarr

You're welcome. I am new to this and am asking support to my university. What is your proposal ? Sincerely yours

gcathelain commented 5 years ago

Dear Carlos,

You can cite me as Guillaume Cathelain, PhD student, CHArt laboratory (Cognition Humaine et Artificielle), EPHE school (École Pratique des Hautes Etudes), PSL University (Paris Sciences Lettres).

Best

eladwass commented 4 years ago

Hello! Is there any news about this PR?

gcathelain commented 4 years ago

Hi, I couldn't find time to update it, sorry about that

Le lun. 2 mars 2020 à 16:17, eladwass notifications@github.com a écrit :

Hello! Is there any news about this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PIA-Group/BioSPPy/issues/56?email_source=notifications&email_token=AG3F7MJYYNJ5GUXOZDGRP4TRFPEWZA5CNFSM4HHCWGZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPWA2Q#issuecomment-593453162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3F7MORLDUQFYXG3OINMLLRFPEWZANCNFSM4HHCWGZQ .

afonsocraposo commented 3 years ago

Done in https://github.com/PIA-Group/BioSPPy/commit/c5bf34b84c9bf1e557465b1e0d350dba33ae5b5b.

afonsocraposo commented 3 years ago

Some issues were found on this module and it was removed from the master branch, https://github.com/PIA-Group/BioSPPy/commit/6977d10794381ab903db2cf0ce8c245d32b1bbd7. This module is available in its own branch bcg, https://github.com/PIA-Group/BioSPPy/commit/c8559c52568f055c458f049956fab49c0b4e2dea, and it will be merged back once the highlighted TODO issues are fixed.