search

PIA-Group / BioSPPy

Biosignal Processing in Python
Other
569 stars 273 forks source link

Future Warning from sklearn #62

Closed Xiaohong-Deng closed 3 years ago

Xiaohong-Deng commented 5 years ago

The warning comes from storage.py. I think there is a two lines fix. I can create a pull request if it is appropriate. Thanks.

DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. 

Please import this functionality directly from joblib, which can be installed with: pip install joblib. 
If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.

  warnings.warn(msg, category=DeprecationWarning)
finetard commented 4 years ago

Created a pull request resolving this issue. Hoping that will be looked into and merged

65

ghosharindam commented 3 years ago

Can someone review the relevant PR? sklearn is currently at a stable version of 0.23.2 and sklearn.externals.joblib leads to ImportError: cannot import name 'joblib' from 'sklearn.externals'

Only solution currently is downgrading sklearn.

@finetard would it be possible to assign the PR to someone else? @capcarr seems to be presently inactive

finetard commented 3 years ago

@ghosharindam I don't know how to change the reviewer, do I have to issue another PR?

finetard commented 3 years ago

@DominiqueMakowski @herrkaefer @ball-hayden can any of you look into it?

ball-hayden commented 3 years ago

I don't remember anything about this project. Sorry.

finetard commented 3 years ago

@LeafarCoder can you look into it?

LeafarCoder commented 3 years ago

I'm not free at the moment to solve this issue. If until the next month no one solves it I may be free by then to have a look.

MadHuslista commented 3 years ago

@LeafarCoder, Hi! Until today is still not solved, could yo look into it? Thanks in advance!

MadHuslista commented 3 years ago

Created a pull request resolving this issue. Hoping that will be looked into and merged

65

Hi everyone, I believe that I solved the issue copying the changes recommended in #65 and #74 I'm new with biosppy but the error message disappears, and the package appears to work properly.

afonsocraposo commented 3 years ago

Thank you @MadHuslista for your input. You were right, PRs #65 and #74 indeed fix this issue. The lastest commit https://github.com/PIA-Group/BioSPPy/commit/57fd8887546ecfbeac158399031a90152fa2e4af merges this PRs.