search

PIA-Group / BioSPPy

Biosignal Processing in Python
Other
569 stars 273 forks source link

Removed deprecation warning from sklearn, by importing joblib independently #65

Closed finetard closed 3 years ago

finetard commented 4 years ago

Removed the deprecation warning shown by current sklearn version, by importing joblib independently in biosppy/storage.py rather than from sklearn.externals. Added joblib as a requirement in setup.py, requirements.txt and README.md

TheusStremens commented 3 years ago

Now, this PR is critical. The sklearn removed the joblib from the externals, so, if you try to use the biosppy storage it raises an error of cannot import like

lib/python3.6/site-packages/biosppy/storage.py", line 28, in <module>
    from sklearn.externals import joblib
ImportError: cannot import name 'joblib'