search

PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities
Other
15 stars 9 forks source link

ShotText format missing type field #172

Open nick-falco opened 6 years ago

nick-falco commented 6 years ago

The shottext output format in ph5toexml does not include the "type" field that is found in the QuakeML output. What do you think of adding this field to the shottext output format?

derick-hess commented 6 years ago

Seems like a good idea to me. Though for many we won't know the type and it's not saved in ph5 currently.

nick-falco commented 6 years ago

Looking into this further, I've found that the "type" field is being hardcoded to "controlled explosion".

See https://github.com/PIC-IRIS/PH5/blob/master/ph5/clients/ph5toexml.py#L590.

In my opinion, this is misleading since the shots are not necessarily from explosions (as we found with experiment 12-003).

Perhaps we need to add a shot "type" field to the Sorts_g/Event_t_### table in PH5? This way users can specify the type of shots that are being used. Alternatively we could use the /Experiment_g/Sorts_g/Event_t_###/description_s field, but this is already being defined separately in the QuakeML.

derick-hess commented 6 years ago

We would have to go through the PH5 working group to add any new fields I think. I do think it needs to be added to the event table though

derick-hess commented 6 years ago

QuakeML 2.0 also has more features that will be useful to us. It adds a lot more for doing non earthquake events

ascire-pic commented 3 years ago

Related to issue #210

Event type is not a field that is currently recorded in PH5. Would need to add type to the event metadata/shot table