[BUG] List index out of range in ph5tostationxml when there is no experiment_t in ph5

damhuonglan commented 4 years ago

Describe the bug According to Akram email on 04/06/20 email, she ran to error "list index out of range" when running ph5tostationxml. This causes by the following:

ph5tostationxml was written to look for all master.ph5 (nickname) under the given path even in sub-directories. In this case it look for backup/, test/ directories beside the main directory. I recommend to change it so it look into the path given by user only.
If the ph5 file has no experiment_t, 'list index out of range' error will happen at code lines:https://github.com/PIC-IRIS/PH5/blob/0bd47ba5113798ed44f9aac9683c25f8a1e20444/ph5/clients/ph5tostationxml.py#L625-L627 A clearer error message should be given here to explain the situation.

To Reproduce

ph5tostationxml -n master.ph5 -p ~/Desktop/ph51/Working/Playa2/PH5/Sigma/ --level=network -f TEXT

ph5.clients.ph5tostationxml - ERROR: list index out of range

damhuonglan commented 4 years ago

@dsentinel should I fix this in one PR only.

damhuonglan commented 4 years ago

Akram already posted this

PIC-IRIS / PH5

[BUG] List index out of range in ph5tostationxml when there is no experiment_t in ph5 #405