modify segdtoph5 for SmartSorlo

PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities

Other

15 stars 9 forks source link

modify segdtoph5 for SmartSorlo #451

Closed damhuonglan closed 3 years ago

damhuonglan commented 3 years ago

What does this PR do?

Modify segdreader.py and segd2ph5.py so that dumpfair and segdtoph5 commands will work with segd files created by SmartSolo

Relevant Issues?

This PR doesn't solve issue #450 but works on SmartSolo like that issue.

Checklist

[ ] This PR is not directly related to an existing issue (which has no PR yet).
[ ] All tests pass.
[ ] Any new or changed features have are documented.
[ ] Changes have been added to CHANGELOG.txt .
[ ] First time contributors have added your name to CONTRIBUTORS.txt .

hrotman-pic commented 3 years ago

For ingestion, am I testing command-line only or am I also testing pforma?

On using dumpfair, I will test how it works currently and under this PR. (dumpfair could read SmartSolo SEG-D in September? 2019, but I don't know if it read it correctly. unsimpleton could also rename the SmartSolo SEG-D files.)

damhuonglan commented 3 years ago

@hrotman-pic Just try with dumpfair and segdtoph5 first to see the values created from SmartSolo are correct and let me know. We will test later with other tools. My modification on segdreader affect both dumpfair and segdtoph5. I don't know if you have another way besides tools in ph5 to read segd to compare with the result created by my modified codes or not.