search

PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities
Other
15 stars 9 forks source link

[FEATURE] Make sure DAS serial number is always read as a string #465

Open hrotman-pic opened 3 years ago

hrotman-pic commented 3 years ago

PH5 known to be affected: 09-006.

Type of PH5 likely to be affected: RT130.

In the validate output for this archive, there are references to DAS serial numbers like 9.00E+45, where the DAS serial number is actually 9E45.

If this is happening when messages are printed in validate, I request that DAS serial numbers be read as a string and not converted to scientific notation.

After thinking about this some more, I can also see this happening at the array table level; many spreadsheet editors will see 9E45 and format the cell to scientific notation, unless the cell is otherwise formatted beforehand. If the problem is at the array table level, can ph5_validate give an error for any DAS S/N that contains the string E+? This will let us catch existing archives with the problem so the array tables can be fixed.

hrotman-pic commented 3 years ago

Modified request for this issue based on PH5 meeting: scientific notation is present at array table level. Can ph5_validate produce an error for any DAS serial number containing the string E+?