PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities
Other
15 stars 9 forks source link

Fix 476 combine array entries #479

Closed damhuonglan closed 3 years ago

damhuonglan commented 3 years ago

What does this PR do?

SmartSolo split data for the same deployment into different files. As the result there are different entries for the same deployment in array table. This PR modify segdtoph5 to combine array entries within the same deployment (with overlap or no gap) into one entry. This combination is applied for SmartSolo only.

Relevant Issues?

Checklist

ascire-pic commented 3 years ago

Looks good; tested with a few different subsets of data including continuous SmartSolo data, SmartSolo data with a gap, and Fairfield data. All resulting array tables appear to be correct.

damhuonglan commented 3 years ago

@ascire-pic I'm sorry that I assigned you this PR instead of asking you to review it. Can you go to the top of the PR to approve it please?