PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities
Other
15 stars 9 forks source link

[FEATURE]Improve validation for noven #492

Open damhuonglan opened 2 years ago

damhuonglan commented 2 years ago

noven appears to be insufficient in validating values added to array and event tables. Users thinks it should be helpful to catch as many as possible the errors when the values are entered so the effort and time to run commands between noven and ph5validate will not be wasteful.

Current value checks in noven

hrotman-pic commented 2 weeks ago

Thank you for looking up these checks, Lan. These checks look like they are older standards.

Suggestions of column checks to add for receivers: SEED channel name, SEED station name, location/X/value_d, location/Y/value_d, location/Z/value_d. I also think sensor manufacturer, sensor model, das manufacturer, and das model should be required, but some of these 4 checks may currently be only warnings in ph5_validate. Sensor model and das model are used in resp_load so I would think resp_load would not run correctly if those were missing.

Suggestions of column checks to add for shots: Array, location/Z/value_d.

I think it would also be good to discuss using the name station in place of receiver and the name event in place of shot. The PH5 documentation has moved this direction. The use of receiver is most likely to cause confusion because there is a Receiver_t that has a different function than the station/receiver table(s) Array_t.