I500 fix das_t - Githubissues

PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities

Other

15 stars 9 forks source link

I500 fix das_t #503

Closed damhuonglan closed 2 years ago

damhuonglan commented 2 years ago

What does this PR do?

SmartSolo filenames create ordering problem when read into ph5 which the cause of the issue in #500. This PR is to fix the problem:

New tool: fix_das_t_order to fixed ordering problem in given ph5. Remember to run: pip install -e . before using the tool
segdtoph5: reorder das_t for new ph5
ph5_validate: give error message for das_t's ordering problem

Checklist

[ ] This PR is not directly related to an existing issue (which has no PR yet).
[ ] All tests pass.
[ ] Any new or changed features have are documented.
[x] Changes have been added to CHANGELOG.txt .
[ ] First time contributors have added your name to CONTRIBUTORS.txt .

hrotman-pic commented 2 years ago

It looks like this will resolve issue 500. I'm testing a range of cases before I leave my complete review.

Can I ask for 2 changes (I think they are small): 1) In the help for fix_das_t_order, could you change the statement "Reorder das_t according to channel_number_i and time." To instead be: "Reorder das_t according to channel_number_i and time. Will update all das_t in an experiment."

2) In segdtoph5, could you change it again so it will reorder Fairfield das_t also? I am sorry, I updated the issue with a Fairfield example after you made this PR and did not mention that Fairfield could be affected as well as SmartSolo.