PIC-IRIS / PH5

Library of PH5 clients, apis, and utilities
Other
15 stars 9 forks source link

Nodal experiments: assign valid unit to location/Z/unit_s field in Array_t #545

Open hrotman-pic opened 1 month ago

hrotman-pic commented 1 month ago

This field is currently 'unknown'. In a Fairfield experiment, the units are actually meters (m). In a SmartSolo experiment, the location/Z/value_d field cannot be populated correctly in Array_t because it is not populated or is not correct in the .segd. For consistency among node types and to follow expectations, if the SmartSolo location/Z/value_d field can ever be populated correctly its units should also be m. This approach will also follow the manual updates to Array_t the group has been doing for SmartSolo experiments.

This is a non-critical request and can probably be combined with another update to reading nodal data and creating Array_t entries. If the field is left as 'unknown', it prompts a warning in ph5_validate.