Timezone in GPX output is incorrect

PIFSC-Protected-Species-Division / cruise-maps-live

This repository contains code necessary to generate daily maps of the cetacean survey cruises

https://storymaps.arcgis.com/stories/b3bbf0e90d0141f7bf47edc5339ccb7a

MIT License

3 stars 0 forks source link

Timezone in GPX output is incorrect #15

Closed sfregosi closed 1 year ago

sfregosi commented 1 year ago

It is noted as 'Z' but it is local time, so need to convert that to UTC, then write as UTC for the .gpx.

Need to

apply a time zone to the date times that are read in (they default to UTC bc none specified)
then convert these to UTC before printing into .gpx string
may be helpful: https://lubridate.tidyverse.org/reference/with_tz.html

Alternative, may be able to specify HST as the timezone within the .gpx string?

https://qlandkartegt-users.narkive.com/0mbEZwrT/time-zone-in-gpx-files

sfregosi commented 1 year ago

used lubridate::force_tz to just fix the timezone of all datetime objects + changed the output format for the inputs to the .gpx. Tested and it seems to be working but will hold off to pull into main until after tomorrows auto run and autocommit of last day of leg 1.

sfregosi commented 1 year ago

auto run and autocommit of last day worked (not including these changes; found new issue...#16, but #12 seems to be resolved!) so going to create pull request to update main with this new fix. Then will re-run to test.