PIFSC-Protected-Species-Division / cruise-maps-live

This repository contains code necessary to generate daily maps of the cetacean survey cruises
https://storymaps.arcgis.com/stories/b3bbf0e90d0141f7bf47edc5339ccb7a
MIT License
3 stars 0 forks source link

Map legend is cut off #30

Closed ybarkley closed 1 year ago

ybarkley commented 1 year ago

@sfregosi @badgerjj

I noticed the map legend is cut off as it is getting longer with more species. Maybe just a tweak to the margins? Hopefully! 814-dailyMap_visuals

sfregosi commented 1 year ago

Good catch @ybarkley.

When I made the 'max' map with all possible sightings it expanded the legend into two columns, which totally messed up the size of the map. I was able to get around this by just printing it at twice the size (20 wide by 10 tall instead of 10 in wide by 5 in tall).

I could try to just resize it that way, but will hold off to see if @badgerjj has any other insight since she had so much fun with playing with sizing when building the mapping function :)

badgerjj commented 1 year ago

Haha. I would say if the number of species were to vary we could make a function to size the map according to needs, but as it just grows I think Selene’s suggestion works great! Janelle J. Badger, Ph.DStatistician/Research Ecologist, Cetacean Research ProgramNOAA Fisheries | Pacific Islands Fisheries Science CenterOn Aug 14, 2023, at 5:13 PM, sfregosi @.***> wrote: Good catch @ybarkley. When I made the 'max' map with all possible sightings it expanded the legend into two columns, which totally messed up the size of the map. I was able to get around this by just printing it at twice the size (20 wide by 10 tall instead of 10 in wide by 5 in tall). I could try to just resize it that way, but will hold off to see if @badgerjj has any other insight since she had so much fun with playing with sizing when building the mapping function :)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

sfregosi commented 1 year ago

Ok I've got a workable solution that I'm not totally happy with but it will hold us over for a while.

Temporary Solution

Remaining Issue

Possible Further Solutions

ybarkley commented 1 year ago

I think the if/else to make the map size grow based on number of columns is our best solution. No need to spend more time on this :) I'll check whether I need to manually change things on the website once we add columns. Thank you @sfregosi for your deep diving on this matter!

sfregosi commented 1 year ago

thanks @ybarkley I just pushed all the changes (also re-ran 812 because @mchill808 said she updated it) so we can see how it looks on the site now!