search

PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

Merge/Code Styler broke SSplotretrocomp #12

Closed efletcherPIFSC closed 2 years ago

efletcherPIFSC commented 2 years ago

Code styling workflow for #11 was not a success. There were no changes when re-running it. Using the R package checker traced the error to SSplotretrocomp.

The plot_retro function ends prematurely. Commit a6f5d7a1a985c6d6f3b7689c1cce810942afcb8f duplicates the legend conditional and values for rho, 'fchro, andrho.table`. The cause of this was either:

https://github.com/PIFSCstockassessments/ss3diags/commit/23d115fbd226fdf5cbdcfae2051c054413beab82#diff-2443c26dfd17ed36bc6b2c568397e623b87df4da8442d80ef53155b0a821dfa9

efletcherPIFSC commented 2 years ago

Reopened issue, due to NAs for rho and forecastRhoand "Mohn's rho" reknitting README with the previous commit af06721fdbe017a169d0a927bf2508450396ffa0. Found that rho.i and fchro.i was moved outside for loop recent commits.

Commit d10e320a8be03c2c09023dcd4ec7bba79467077f places back rho.i and fchro.i back into the for loop. Reknitting the README regains the reproducible results.