PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

SSplotJABBAres issue #17

Closed MOshima-PIFSC closed 2 years ago

MOshima-PIFSC commented 2 years ago

I received an email from Max that he experienced a bug in the SSplotJABBAres function. In the PIFSCstockassessment version, discard length composition gets combined as replicates in the JABBA plot and RMSE and it messes up the analysis. Figure of issue included below.

RunTestResidual_R1

JointResiduals_R1

He noted that this issue was not present in the JABBA-hosted version. Image below of how it should look: JointResiduals_Northern shrimp