PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

Fixup dplyr globals #53

Closed efletcherPIFSC closed 2 years ago

efletcherPIFSC commented 2 years ago

Resolves #52. with the R package checker. However, this fix does not resolve the SSplotJABBAres filename issues that is causing failing tests,

MOshima-PIFSC commented 2 years ago

@efletcherPIFSC The changes look good to me. We can merge the SSrmse function into the main branch but for now wait on the SSplotJABBAres update. There are still some issues with the code, it doesn't export the plot and the xlim cannot be specified.