PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

SSplotJABBAres output issue #54

Closed efletcherPIFSC closed 2 years ago

efletcherPIFSC commented 2 years ago

Changes related to #50 caused errors in the test-plotJABBA..r: intended filenames of the written plot PNG were not found when the test script expects it to be true.

Ran test-plotJABBA.r data setup and the first ss3diags::SSplotJABBAres manually on R console. The plot does get outputted, path <- file.path(tempdir(),"test-runs") is created, however file.exists(file.path(path, paste0(filenameprefix"jabbaresidual.png"))) is FALSE (which should be TRUE).

Looking at the temp dir, the written file was saved as a default tempfile.

The checks errors began with commit 072c49df956eaee9b51ae23026d29ea213ee11db, and relate to this issue. Looking at the changes for SSplotJABBAres, the par is set to TRUE.

Reverting par to FALSE fixes this issue.