PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

Logo! #76

Closed MOshima-PIFSC closed 1 year ago

MOshima-PIFSC commented 1 year ago

One crucial thing ss3diags is missing is a logo! My friend @pdimens has offered to design a logo for the package (see examples of his work here, here, and here). If we can come up with some themes of the package, he will come up with some designs. Since Stock Synthesis doesn't really have a logo and the r4ss logo is essentially just it's name, I think we have a lot of avenues we can go down for this. Some themes to get us started could be:

@efletcherPIFSC and @fecor21 feel free to suggest other ideas!! If we get a cool logo we could even make hex stickers for the NSAW meeting in May to pass out....

pdimens commented 1 year ago

Hey all, it's a pleasure for us to collaboratively come up with something together. Meg has been very vocal about her enthusiasm regarding working on ss3diags and the ways in which she hopes to make this package as user-friendly and well-received as possible. I would love to hear some ideas from you all make up some drafts that we can further refine. Here's some of the stuff I've done over the years: No_MGL_logo_tamucc colors image LepWrap harpy gust image image Tidier_jl_logo image

efletcherPIFSC commented 1 year ago

Thanks @MOshima-PIFSC. We can add it to the ss3diags package website.

@pdimens thank you for giving your contributions to the project. Your work are top-notch, and looking forward to work with you and Meg on this.

For myself, the ss3diags logo should easily represent what the package was designed for, written in the README description:

The R package ss3diags enables users to apply advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.

pdimens commented 1 year ago

Working off of some of the ideas Meg presented, here is a draft. image

ss3diags indeed incorporates a fish with a stethoscope and an otherwise sunrise/marine color scheme. On the other hand, r4ss incorporates the current/original R4SS logo, while re-imagining the colors in the style of a kobe plot, with some additional flair.

pdimens commented 1 year ago

Here are also dark variants of the drafts image

efletcherPIFSC commented 1 year ago

@pdimens

Looks good. For ss3diags, the "fish with a stethoscope" looks like it should stand out more. Its outline blends in too well with the light/dark separators. The text could be more visible, less transparent.

pdimens commented 1 year ago

@efletcherPIFSC here is the current draft, incorporating your ideas image

pdimens commented 1 year ago

Here's an even simpler version, which is my favorite so far. image

MOshima-PIFSC commented 1 year ago

@pdimens I love this! I think this is great. @efletcherPIFSC and @fecor21 should this be the final version?

fecor21 commented 1 year ago

Aloha Team, Sorry I am late to the party. @pdimens https://github.com/pdimens this is absolutely great!!! Super mahalo for creating this for us. Yeah, let's go with this one! Again, this is SO COOL!!! FC

On Wed, Mar 22, 2023 at 9:59 AM Meg Oshima @.***> wrote:

@pdimens https://github.com/pdimens I love this! I think this is great. @efletcherPIFSC https://github.com/efletcherPIFSC and @fecor21 https://github.com/fecor21 should this be the final version?

— Reply to this email directly, view it on GitHub https://github.com/PIFSCstockassessments/ss3diags/issues/76#issuecomment-1480186089, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCZIXJXV5DAYDYIPHWILO3W5NKZLANCNFSM6AAAAAAV55H7Q4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Felipe Carvalho, Ph.D.

Supervisory Research Mathematical Statistician Stock Assessment Program Leader NOAA Pacific Islands Fisheries Science Center Website: PIFSC Stock Assessment https://pifscstockassessments.github.io/ | PIFSC https://www.fisheries.noaa.gov/region/pacific-islands#science | Bio https://www.fisheries.noaa.gov/contact/felipe-carvalho-phd

pdimens commented 1 year ago

That's great to hear. I emailed Meg the SVG versions of both logos because I wasn't sure where the files would go as a PR. When you're content, feel free to close this issue.

MOshima-PIFSC commented 1 year ago

@iantaylor-NOAA, @k-doering-NOAA, and @kellijohnson-NOAA, my friend @pdimens offered to make a logo for ss3diags and while he was working on it he also came up with an updated version of the r4ss logo. If you are interested in using it or want to talk with him, feel free to reach out to him (or reply here) and he'd be happy to work with you.

k-doering-NOAA commented 1 year ago

@MOshima-PIFSC and @pdimens, wow, these are so cool! It's up to Ian to decide on the r4ss logo, I think :)

kellijohnson-NOAA commented 1 year ago

Yes, very nice!

iantaylor-NOAA commented 1 year ago

Thanks @MOshima-PIFSC and @pdimens! I would happily adopt this far-superior r4ss logo. The original was created very quickly to avoid having to look at the automatically generated block of squares created by github, but the colors on the current logo bug me when I see them all the time in my commit graphs.

@pdimens, would you be willing to try using lowercase "r4ss" instead? The package started as "R4SS" but is almost always referred to as "r4ss" now (I will hold back from providing a detailed history of the evolution).

Lastly, @pdimens, by incorporating the logo into an open-source package that is being developed by the federal government, I think you would be relinquishing any form of copyright on this. I assume you're OK with that.

pdimens commented 1 year ago

@iantaylor-NOAA regarding copyright, any logos I make for open source projects, I don't hold rights to. Just a labor of love.

I'm glad you are all fans of the logo I mocked up. I will make the edits a little later today or tomorrow and post it here for review.

pdimens commented 1 year ago

@iantaylor-NOAA image

iantaylor-NOAA commented 1 year ago

@pdimens, thank you. It looks good to me. Can you provide a high-resolution version with transparent background? You're welcome to post the image here, send me via email to ian.taylor@noaa.gov, or fork the r4ss package and issue a pull request. I see from https://usethis.r-lib.org/reference/use_logo.html that the standard is to put logos into man/figures/logo.png, but you probably know more about this than me.

pdimens commented 1 year ago

@iantaylor-NOAA fantastic, the PR has been made: https://github.com/r4ss/r4ss/pull/790

MOshima-PIFSC commented 1 year ago

I'm adding the ss3diags logo files to the man/figures directory and closing issue.

iantaylor-NOAA commented 1 year ago

Thanks @MOshima-PIFSC and @pdimens. The r4ss logo is a big improvement.

iantaylor-NOAA commented 1 year ago

I'm reopening this thread for a brief logo question for @pdimens.

The new logos are now out in the wild on https://pifscstockassessments.github.io/ss3diags/ and https://r4ss.github.io/r4ss/ and I notice that the SVG version is showing up with a different font than the PNG in Chrome on my Windows computer (comparison screenshot below). I'm not an expert with SVG and don't have Inkscape installed right now, but I gather this has to do with the specified font not being available and the default getting substituted. The {pkgdown} documentation says SVG is recommended, https://pkgdown.r-lib.org/reference/build_favicons.html, but I'm assuming we could just choose PNG instead and solve the problem that way. Any other suggestions?

image

pdimens commented 1 year ago

@iantaylor-NOAA that's my bad. I always convert text to objects in SVG to avoid font-rendering issues and forgot to do it for this one. You're right for noticing it's rendering differently and thanks for bringing it up. I'm a bit swamped today with work, but can easily fix and submit a new PR shortly after my workday ends (EST).

iantaylor-NOAA commented 1 year ago

@pdimens, no rush, good to hear you have an easy fix.

iantaylor-NOAA commented 1 year ago

I came back to close this issue once again but I see that I just commented but forgot to reopen Now it is truly closed once again as the updated r4ss logo is in place and looks good. Thanks again @pdimens! image