search

PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

r4ss dependency update (r4ss dplyr/kableExtra fix) ; remove dplyr from NAMESPACE #84

Closed efletcherPIFSC closed 1 year ago

efletcherPIFSC commented 1 year ago

Resolves #82, resolves #83 Updated r4ss dependency that fixed a function name conflict with dplyr and kableExtra libraries dependencies (#83)

Remove dplyr imports (and roxygen tags) from NAMESPACE, and append dplyr function calls with quote notation (dplyr::)

Updated default summaryoutput used in SSplotModelComp and ss3rep used in SSplotRunsTest (#78)

efletcherPIFSC commented 1 year ago

I had issues with r4ss's kableExtra error with ghactions "call-doc-and-style-r" workflow, This error was a side effect of r4ss's kableExtra issues as described in nmfs-fish-tools/ghactions4r#69. The action error was unable to find where r4ss was importing kableExtra:

Error in utils::download.file(url, path, method = method, quiet = quiet,  : 
  cannot open URL 'https://api.github.com/repos/r4ss/r4ss/contents/DESCRIPTION?ref=importFrom_kableExtra'

Updating r4ss dependency to r4ss/r4ss#821, resolves this.