PIFSCstockassessments / ss3diags

R package with advanced diagnostics to evaluate a Stock Synthesis model. Diagnostics include residual analyses, hindcasting and cross-validation techniques, and retrospective analyses.
http://pifscstockassessments.github.io/ss3diags/
2 stars 4 forks source link

Feat update testing fixtures #88

Closed MOshima-PIFSC closed 1 year ago

MOshima-PIFSC commented 1 year ago

Changes included in this PR:

These changes will move us toward being able to remove the large .rda files (simple.rda and retroSimple.rda) in the future. The next step will be during the documentation milestone to update the vignettes to use these structures.

This new workflow should replace the current call-r-cmd-check.yml workflow.

efletcherPIFSC commented 1 year ago

@MOshima-PIFSC The r package checker found errors in the test code, but it was due to checking if stock synthesis was installed in my system,

r4ss has a test_that method that skips the test if the stock synthesis executable is not on the system: https://github.com/r4ss/r4ss/blob/9d592166e3415f61875a9e19bc0741c0a0c5a5b0/tests/testthat/test-runs.R#L20)

efletcherPIFSC commented 1 year ago

R-package check with bugfixes resolves #89 issue.