PILLUTLAAVINASH / google-enterprise-connector-manager

Automatically exported from code.google.com/p/google-enterprise-connector-manager
0 stars 0 forks source link

Use PropertyPlaceholderConfigurer for feedLoggingLevel property #112

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
When a customer was asked to turn off feed logging,
he commented out the feedLoggingLevel property in
the CM applicationContext.properties rather than 
setting the property value to "OFF". 

What is the expected output? What do you see instead?

The customer expected that feed logging would be 
disabled.  Instead, the Connector Manager fails to
start up when Spring complains of a missing placeholder.

Please use labels and text to provide additional information.

Commenting out the property is completely understandable, 
as one sees that the TeedFeedFile property is commented 
out by default, and if someone had set a logging level 
for debugging, they might want to preserve the level used 
for future debugging.

One easy solution is to create a PropertyPlaceholderConfigurer
bean in applicationContext.xml.  This can provide a default
value for this property.  We could also probably provide a
default gsa.feed.port value of 19900.

Original issue reported on code.google.com by Brett.Mi...@gmail.com on 10 Dec 2008 at 5:36

GoogleCodeExporter commented 8 years ago
Fixed in revision r1322

This is a couple usability and performance improvements,
mostly dealing with logging.

When a customer was asked to turn off feed logging,
he commented out the feedLoggingLevel property in
the CM applicationContext.properties rather than
setting the property value to "OFF".  This caused
the Connector Manager to fail to start up with a
failure to resolve a property placeholder.

One easy solution was to provide a default value for
the property in the PropertyPlaceholderConfigurer
bean of the Connector Manager's applicationContext.xml
file.

This same customer complained about poor feed
performance when teedFeedFile was enabled.  Since
the teedFeedFile tends to get volumes of data, I
increased the BufferedOutputStream buffer size from
the default 512 bytes to 32768 bytes.

Change Log:
----------
M  connector-
manager/source/java/com/google/enterprise/connector/pusher/DocPusher.java
   - Increase the teedFeedFile BufferedOutputStream
     buffer size to improve feed logging performance.

M  connector-manager/source/java/com/google/enterprise/connector/pusher/GsaFeedC
onnection.java
   - Enhanced logging in sendData() to help identify
     performance bottlenecks.

M  connector-manager/etc/applicationContext.xml
   - Provide default values for feedLoggingLevel and
     gsa.feed.port properties in the
     PropertyPlaceholderConfigurer.

Original comment by Brett.Mi...@gmail.com on 20 Dec 2008 at 6:59

GoogleCodeExporter commented 8 years ago

Original comment by jl1615@gmail.com on 12 Jan 2009 at 3:29