search

PILLUTLAAVINASH / google-enterprise-connector-manager

Automatically exported from code.google.com/p/google-enterprise-connector-manager
0 stars 0 forks source link

Enhanced Exception Handling around AuthN/AuthZ #126

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Issue 72 and Issue 108 dealt with proper handling of Exceptions thrown
during Traversal and Pushing.  

A similar sweep needs to be made through the interfaces for
AuthenticationManager and AuthorizationManager.

Original issue reported on code.google.com by Brett.Mi...@gmail.com on 3 Mar 2009 at 12:47

GoogleCodeExporter commented 8 years ago

Original comment by jl1615@gmail.com on 10 Mar 2009 at 7:32

GoogleCodeExporter commented 8 years ago 
Fixed in Connector Manager revision r1573

Issues 72 and 108 provided much better exception handling
when dealing with the traverser/pusher/feeder.  Calls to
the Collection, CollectionType, Session, AuthenticationManager,
and AuthorizationManager should be similarly protected against
unexpected Exceptions thrown.

Change Log:
----------
M  projects/connector-manager/source/java/com/google/enterprise/connector/instan
tiator/ConnectorInterfaces.java
   - catch Exception in calls to Collection, Session, AuthenticationManager, and
     AuthorizationManager, usually rethrowing as InstantiatorException.

M  projects/connector-manager/source/java/com/google/enterprise/connector/manage
r/ProductionManager.java
   - catch Exception being thrown when accessing the AuthenticationManager,
     AuthorizationManager, and the objects returned by their interfaces.
   - catch Exception being thrown when calling ConnectorType.getConfigForm(),
     and rethrow as InstantiatorException.

M  projects/connector-manager/source/java/com/google/enterprise/connector/instan
tiator/SpringInstantiator.java
   - catch Exception being thrown when calling
ConnectorType.getPopulatedConfigForm()
     and rethrow as InstantiatorException.

M  projects/connector-manager/source/java/com/google/enterprise/connector/instan
tiator/InstanceMap.java
   - catch Exception being thrown when calling ConnectorType.validateConfig()
     and rethrow as InstantiatorException.

M  projects/connector-manager/source/java/com/google/enterprise/connector/traver
sal/QueryTraverser.java
   - catch Exception being thrown when calling setTraversalContext,
     log and continue.

M  projects/connector-
manager/source/java/com/google/enterprise/connector/servlet/GetConfigForm.java
   - catch InstantiatorExceptions from Manager.getConfigForm() and
     return an appropriate status from the servlet.

M  projects/connector-manager/source/java/com/google/enterprise/connector/servle
t/SetConnectorConfig.java
   - catch InstantiatorExceptions from Manager.getConfigForm() and
     return an appropriate status from the servlet.

M  projects/connector-
manager/source/java/com/google/enterprise/connector/manager/Manager.java
   - Manager.getConfigForm() may throw InstantiatorException,

M  projects/connector-manager/source/javatests/com/google/enterprise/connector/s
ervlet/SetConnectorConfigNoGSA.java
   - catch InstantiatorExceptions from Manager.getConfigForm() and
     return an appropriate status from the servlet.

Original comment by Brett.Mi...@gmail.com on 17 Mar 2009 at 10:25

GoogleCodeExporter commented 8 years ago

Original comment by Brett.Mi...@gmail.com on 16 May 2009 at 9:08