PILLUTLAAVINASH / google-enterprise-connector-manager

Automatically exported from code.google.com/p/google-enterprise-connector-manager
0 stars 0 forks source link

Form Snippets with script and embedded CDATA but no sensitive data are sent to the GSA with nested CDATA and can't be parsed #139

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Using 1.3.2 tagged release.

What steps will reproduce the problem?
1. Create a formSnippet with a <script> protected by CDATA but no sensitive
data
2. Try to create a Connector on the GSA using that formSnippet
3. GSA shows XML parsing error.

What is the expected output? What do you see instead?

GSA should show the form.

Original issue reported on code.google.com by mgron...@gmail.com on 6 Apr 2009 at 7:13

GoogleCodeExporter commented 8 years ago
Fixed mgronber/fix-issue-139@1649

Log message

Added back the call to removeNestedMarkers() for those cases where the
formSnippet does not contain any sensitive data and is not filtered but simply
returned from the call to filterSensitiveData().  In those cases, if the
formSnippet contains script code it many also contain CDATA markers which will
become nested when the from is wrapped again.

Tests Passed:

  - All Unit tests
  - Tested on GSA with form with script and no sensitive data.

Change Log:

  M source/java/com/google/enterprise/connector/servlet/ConnectorManagerGetServl
et.java
    - Put back the call to filter nested markers to cover those cases where the
      form does not contain any sensitive data but may contain CDATA markers for
      scripts.

Original comment by mgron...@gmail.com on 6 Apr 2009 at 8:18

GoogleCodeExporter commented 8 years ago
Fixed in r1650 which was the merge of mgronber/fix-issue-139@1649 into trunk/

Original comment by mgron...@gmail.com on 6 Apr 2009 at 8:20