PILLUTLAAVINASH / google-enterprise-connector-manager

Automatically exported from code.google.com/p/google-enterprise-connector-manager
0 stars 0 forks source link

ServletUtil.prependCmPrefix assumes undocumented syntax in the ConfigureResponse #31

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Generate a ConfigureResponse with an input element that doesn't include
the string name=" in the input elements, for example, using name=' instead.
2. Submit the Add Connector page in the GSA

What is the expected output? What do you see instead?

I expected to go back to the Connectors page with the new connector listed.
Instead, I am returned to the Add Connector page with a new, empty config
form. Both of the empty config forms are missing the CM_ prefix on the
input element names.

Please use labels and text to provide additional information.

The PREFIX_NO_CM regex in ServletUtil should be a little more flexible, I
think. In particular, whitespace and both forms of quotes should be
allowed. Even if the regex itself isn't changed, the regex should be
documented in ConfigureResponse, and possibly live there or in
SpiConstants, rather than in a hidden implementation class.

Original issue reported on code.google.com by jl1615@gmail.com on 7 Feb 2007 at 9:08

GoogleCodeExporter commented 8 years ago
Google Bug #244005

Original comment by vjo...@gmail.com on 9 Feb 2007 at 5:26

GoogleCodeExporter commented 8 years ago
Fixed in R473.

Original comment by mgron...@gmail.com on 3 Oct 2007 at 10:22

GoogleCodeExporter commented 8 years ago

Original comment by mgron...@gmail.com on 3 Oct 2007 at 11:01