PILLUTLAAVINASH / google-enterprise-connector-manager

Automatically exported from code.google.com/p/google-enterprise-connector-manager
0 stars 0 forks source link

Connector Schedule interacts badly with Connector Configuration #55

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Click Add/Edit to edit a connector configuration.
2. GSA calls getPopulatedConfigForm and displays the Add Connector page.
3. Click Add Line to Schedule.
4. GSA calls getPopulatedConfigForm (see issue 54) and adds a schedule line.
5. Allow crawling from 2:00 AM to 2:00 AM in the new schedule line and click 
Save 
Configuration.
6. GSA does not call any ConnectorType methods, and it displays the Add 
Connector page with a 
schedule error and no form snippet.
7. Delete the added schedule line and click Save Configuration.
8. GSA calls getConfigForm [sic] and displays the Add Connector page with an 
empty form 
snippet.

What is the expected output? What do you see instead?

That's just one example. As an aside, the root cause of the error is that it 
doesn't seem to be OK 
to have two empty intervals in the schedule. One empty interval is OK, and 
indicates either 
always run (12:00 AM to 12:00 AM) or never run (any other empty interval). So 
I'm using the two 
empty intervals here to trigger the schedule error, which is all I really 
needed.

This page essentially has two separate forms, but they are combined in a single 
HTML form. If 
there are validation errors in the schedule, then changes to the connector 
configuration are 
ignored. No changes are made to the stored properties file in the above 
scenario, so if you know 
this you can go back to the Connectors page and click Add/Edit again to recover 
a form with the 
connector configuration filled out (minus any intermediate edits to the 
configuration).

What version of the product are you using? On what operating system?

GSA 5.0.0.G.14, Connector Manager 1.0.2.

Please provide any additional information below.

One possible fix might be breaking the form into two forms, and setting the 
configuration and 
schedule separately (as two forms on the same page, or as a semi-wizard like 
the LDAP settings, 
etc.). Another is calling validateConfig even if there are schedule errors. Yet 
another is use 
JavaScript to flag an error if both the Connector Configuration and Connector 
Schedule are edited 
at the same time; that seems icky from a UI perspective but doesn't require 
changes under the 
covers.

Original issue reported on code.google.com by jl1615@gmail.com on 17 Oct 2007 at 11:56

GoogleCodeExporter commented 8 years ago
P2, since I think that schedule errors are unlikely. Still, it does silently 
drop user input on the floor, and raises the 
spectre of data loss if the empty form is submitted.

Original comment by jl1615@gmail.com on 19 Oct 2007 at 5:24

GoogleCodeExporter commented 8 years ago
GSA-only bug.  We will make sure that a bug is opened.

Original comment by donald.z...@gmail.com on 18 Apr 2008 at 10:20

GoogleCodeExporter commented 8 years ago

Original comment by jl1615@gmail.com on 10 May 2008 at 3:18

GoogleCodeExporter commented 8 years ago
This is a duplicate of Google bug #742428

Original comment by jl1615@gmail.com on 11 Mar 2009 at 4:57