search

PIP-Technical-Team / pip_ingestion_pipeline

0 stars 0 forks source link

Add `survey_pop` to DSM and IM tables ? #50

Open Aeilert opened 3 years ago

Aeilert commented 3 years ago

EDIT: It is not clear what the behavior should be. We need to clarify that first.

In cases where we calculate pop in poverty for survey years, we should use a population variable that takes decimal survey years into account.

Such a column is already created within pipdm, but is removed in a later column selection process

https://github.com/PIP-Technical-Team/pipdm/blob/bc017b3c9eb0fdc5ff8d7369a8ede4c1f93e6bc6/R/db_create_lcu_table.R#L132-L136

https://github.com/PIP-Technical-Team/pipdm/blob/bc017b3c9eb0fdc5ff8d7369a8ede4c1f93e6bc6/R/db_create_dsm_table.R#L149

cc: @randrescastaneda, @tonyfujs

Aeilert commented 2 years ago

Bumping this. According to Christoph PCN uses survey year to calculate pop in poverty. If that is the case we should (probably) change how we calculate this for PIP as well.

@tonyfujs, @randrescastaneda : Could we confirm what PCN does?

If we change we need to add the survey_pop column to the pipeline outputs, as well doing some changes in the pipapi.