search

PIP-Technical-Team / pipapi

What the Package Does (One Line, Title Case)
https://pip-technical-team.github.io/pipapi/
Other
3 stars 0 forks source link

Incorporate validation of version together with other #246

Open Aeilert opened 2 years ago

Aeilert commented 2 years ago

It would be beneficial to move all the API input argument checks to the same location in endpoints.R.

Incorporate https://github.com/PIP-Technical-Team/pipapi/blob/a14f5ede5e30a736c927d12f50ee051251fb74ff/inst/plumber/v1/endpoints.R#L15-L25

together with

https://github.com/PIP-Technical-Team/pipapi/blob/a14f5ede5e30a736c927d12f50ee051251fb74ff/inst/plumber/v1/endpoints.R#L57-L87

randrescastaneda commented 2 years ago

Hi @shahronak47 ,

Can we safely close this?

cc> @tonyfujs

shahronak47 commented 2 years ago

Hi @randrescastaneda , this isn't completed yet. We still have the two checks at two different places in two different filter's.